Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RCA] Remove x-axis and labels from library visualizations #192994

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Sep 16, 2024

Removes y-axis label, x-axis and adjusts height of the component for library visualizations

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team labels Sep 16, 2024
@benakansara benakansara self-assigned this Sep 16, 2024
@benakansara benakansara requested a review from a team as a code owner September 16, 2024 11:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 16, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@benakansara benakansara enabled auto-merge (squash) September 16, 2024 14:03
@benakansara benakansara changed the title [RCA] Remove x-axis from library visualizations [RCA] Remove x-axis and labels from library visualizations Sep 16, 2024
@benakansara benakansara enabled auto-merge (squash) September 16, 2024 17:35
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 16, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 286de70
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192994-286de705550d

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 458.9KB 459.0KB +36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

@benakansara benakansara merged commit bcab410 into elastic:main Sep 16, 2024
22 checks passed
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Sep 16, 2024
@benakansara benakansara added v8.16.0 backport:version Backport to applied version labels auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Sep 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
…92994)

Removes y-axis label, x-axis and adjusts height of the component for
library visualizations

(cherry picked from commit bcab410)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

benakansara added a commit that referenced this pull request Sep 19, 2024
…2994) (#193446)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[RCA] Remove x-axis and labels from library visualizations
(#192994)](#192994)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T20:26:52Z","message":"[RCA]
Remove x-axis and labels from library visualizations
(#192994)\n\nRemoves y-axis label, x-axis and adjusts height of the
component for\r\nlibrary
visualizations","sha":"bcab410c5006e49a37f5eddd5230a6b74593c2d7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","auto-backport","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[RCA]
Remove x-axis and labels from library
visualizations","number":192994,"url":"https://github.com/elastic/kibana/pull/192994","mergeCommit":{"message":"[RCA]
Remove x-axis and labels from library visualizations
(#192994)\n\nRemoves y-axis label, x-axis and adjusts height of the
component for\r\nlibrary
visualizations","sha":"bcab410c5006e49a37f5eddd5230a6b74593c2d7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192994","number":192994,"mergeCommit":{"message":"[RCA]
Remove x-axis and labels from library visualizations
(#192994)\n\nRemoves y-axis label, x-axis and adjusts height of the
component for\r\nlibrary
visualizations","sha":"bcab410c5006e49a37f5eddd5230a6b74593c2d7"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants